Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple references support #29

Open
AlexMost opened this issue Jan 24, 2017 · 3 comments
Open

multiple references support #29

AlexMost opened this issue Jan 24, 2017 · 3 comments

Comments

@AlexMost
Copy link
Contributor

AlexMost commented Jan 24, 2017

For now, to be able to pass multiple references for translation i need to concatenate them with \n symbols.
Would be great if we could pass those references as array. What do you think? I can create PR with this functionality.

@aduth
Copy link

aduth commented Apr 10, 2017

We encountered a need for this as well. What was the reason for closing the issue?

Thanks for the pointer to joining with the newline character. We'll use this as a workaround in the meantime.

@AlexMost
Copy link
Contributor Author

There was no feedback from the author, so I decided to use workaround with joining strings with \n and close the issue)

@smhg
Copy link
Owner

smhg commented Aug 3, 2017

It seems that I never received an e-mail about this issue (and some others).
What you propose sounds reasonable to me (I adopted the project last year). Feel free to create a PR. Preferable one that doesn't break the existing behavior. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants