Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up classes #7

Open
smhg opened this issue Mar 12, 2014 · 1 comment
Open

split up classes #7

smhg opened this issue Mar 12, 2014 · 1 comment

Comments

@smhg
Copy link
Owner

smhg commented Mar 12, 2014

It would be nice to have different classes for the different parameters that each trigger each other and in the end the day/night change.

Roughly:

Settings

IP
triggered by settings
(don't know if this really needs to be a separate class, maybe it is just part of coordinates)

Coordinates
triggered by settings and IP

Timezone
triggered by coordinates

SunCycle
triggered by coordinates and timezone

Each in their own file, each unit tested.
Each with their own caching: persistent (to disk) or in memory.

@smhg
Copy link
Owner Author

smhg commented Oct 30, 2014

Tests: see Package Control's tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant