Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taiwan official name is “Republic of China” #29

Closed
SmileyChris opened this issue Jun 22, 2013 · 5 comments
Closed

Taiwan official name is “Republic of China” #29

SmileyChris opened this issue Jun 22, 2013 · 5 comments

Comments

@SmileyChris
Copy link
Owner

According to Wikipedia, the official name of Taiwan is “Republic of China”.

I fixed it on my fork, but it might have broken some translation.
@SmileyChris
Copy link
Owner Author

body: ! 'Duplicate of #16.'
created_at: '2013-03-29 18:08:00+00:00'
user: ! 'Chris Beaven'
number: 3562142

@SmileyChris
Copy link
Owner Author

body: ! 'Thanks for the report, Antoine.

Django-countries uses the ISO 3166-1
list for country names. See Issue #16 for some more discussion around this.'
created_at: '2013-03-29 18:07:37+00:00'
user: ! 'Chris Beaven'
number: 3562138

@synotna
Copy link

synotna commented Mar 13, 2015

ISO 3166-1 lists Taiwan as Taiwan, Province of China

With common names turned off, django-countries is Taiwan (Province of China)

:)

@SmileyChris
Copy link
Owner Author

Go to https://www.iso.org/obp/ui/#search and search for "tw" and you'll see the parenthesis are correct.

@synotna
Copy link

synotna commented Mar 16, 2015

Apologies as commented in the other ticket, falsely assumed Wikipedia's ISO entries would match!

mitio added a commit to codeeu/coding-events that referenced this issue Oct 1, 2015
@mitio
Exclude Antarctica and rename Taiwan
10b4310 
Antarctica is not a popular destination for coding events. But who
knows--we might have one someday and we can put it back there.

Taiwan was renamed from "Taiwan (A Provice of China)" to just "Taiwan".
It seems that the official name as defined by ISO 3166-1 is the longer
one, but some Taiwanese find it offensive and it's better to leave it to
just Taiwan.

See here for more info:
SmileyChris/django-countries#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SmileyChris @synotna