Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency to Django >= 1.2 #32

Closed
adamn opened this issue Aug 25, 2010 · 4 comments
Closed

Add dependency to Django >= 1.2 #32

adamn opened this issue Aug 25, 2010 · 4 comments

Comments

@adamn
Copy link

adamn commented Aug 25, 2010

easy-thumbnails, as an emerging library, should require Django 1.2+ and should be explicit about it in the setup.py file.

@SmileyChris
Copy link
Owner

I don't see why it needs to be explicit unless there's a requirement. Which there might be, I can't think if it is right now though... I don't mind it not being explicit unless this is the case.

@adamn
Copy link
Author

adamn commented Sep 7, 2010

It should at least require django generally, most of the packages are moving in that direction.

@SmileyChris
Copy link
Owner

Yeah, I guess so. I just seems a bit odd that you'd need to bother putting the dependency for the framework in your application. I'll ask around djangocon to get some opinions :)

@SmileyChris
Copy link
Owner

I'm not going to bother with this for now. No consensus that this is a good idea.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants