Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dmenu-rs and support all base flags for dmenu extension. #265

Closed
1 task done
thebashpotato opened this issue Apr 10, 2023 · 0 comments · Fixed by #266
Closed
1 task done

Support dmenu-rs and support all base flags for dmenu extension. #265

thebashpotato opened this issue Apr 10, 2023 · 0 comments · Fixed by #266
Labels
enhancement New feature or request

Comments

@thebashpotato
Copy link
Contributor

thebashpotato commented Apr 10, 2023

Please describe the change / addition you'd like to see made

  • Is this completely new functionality, or an enhancement to existing functionality? Enhancement to existing functionality.
  • What kind of feature is it that you are requesting?
    • A custom extension

Problem

I personally use the dmenu-rs port of dmenu. The plugin system is better than old-school patching. The problem is the flags are slightly different.
For example the following flags [ -nb, -nf, -sb, and -fn] use a single dash in Suckless dmenu,
but use a double dash in dmenu-rs, which will cause it to not to launch. Also the ability to use a custom font
in dmenu with the fn flag would be nice as to match the bar, and the -b flag would be nice to allow users to place dmenu on the bottom of their screen.

Proposal

Instead of implementing a new DMenuConfigRS extension, modify the current DMenuConfig struct
to account for these changes. I have already implemented all of this functionality and also changed the DMenu API slightly to be a bit more readable and make a clear distinction between launching dmenu via dmenu_run, or launching a menu based dmenu.

Here are the changes in my penrose setup includes some tests. And here they are used in actions. I could merge this into upstream if it sounds like a good idea @sminez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant