Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify OrionModel and OrionController to use the pack summed voltage #178

Closed
ShawnPierpont opened this issue May 4, 2018 · 1 comment
Closed

Modify OrionModel and OrionController to use the pack summed voltage #178

ShawnPierpont opened this issue May 4, 2018 · 1 comment

Comments

@ShawnPierpont
Copy link
Collaborator

Since the pack open voltage was unreliable, the pack summed voltage is now used. The OrionModel and OrionController need to be modified to use this new value.

End goal Modify OrionModel and OrionController to take into account the new value being sent in the CAN message.
ShawnPierpont added a commit that referenced this issue May 4, 2018
@ShawnPierpont
#178 Modified the OrionModel and OrionController to fix this
05e2633 
Pack open voltage in the model and controller is now pack summed voltage

Calculation for the voltage has been modified from divided by 10 to 100.
@ShawnPierpont
Copy link
Collaborator Author

This has been fixed with commit 05e2633 mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShawnPierpont