-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching from mmap to memmap #6
Comments
Hmm, yeah indeed. Thanks for pointing this out. I'll tackle this as soon as I have some time, it should be pretty straightforward. |
Hmm... After some digging, I can't find a way to create a memory-map from a linux file descriptor in memmap-rs, which is exactly the feature I'm using in mmap: https://github.com/vberger/wayland-kbd/blob/master/src/mapped_keyboard.rs#L153-L156 |
@danburkert Nudge, nudge. |
Wait, you can do this already. On unix platforms you have |
Yah the |
Fair point. I'll try this tomorrow. |
@vberger Did you ever look into this? Did it end up being non-trivial? |
Hmm, kinda forgot this, sorry for that... I won't have time to spend on it for the next two weeks unfortunately... :-/ |
All good! Opened a PR for this whenever you have time: #9 |
memmap
is actually maintained.https://github.com/danburkert/memmap-rs
The text was updated successfully, but these errors were encountered: