Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags are ignored because of hardcoded constant typo #1

Open
ChrisCilinoGC opened this issue Jul 27, 2019 · 2 comments
Open

Flags are ignored because of hardcoded constant typo #1

ChrisCilinoGC opened this issue Jul 27, 2019 · 2 comments

Comments

@ChrisCilinoGC
Copy link

Symptom: none of the flags such as -nofp -nofppos -nobdcosm -nobdpos are being obeyed.

Root cause: vicompare-master\Trunk\fix all paths.vi has and array of hardcoded constants
2019-07-26_19h15_25

However the "-" has been stripped away when the flags are parsed in vicompare-master\Trunk\executables\parse argument.vi therefore there are no matches in the algorithm and the flags are never set.

The easiest fix is to change the hardcoded constant to not include the "-". However I suspect the "better" fix is likely in the parser itself.

@unifab unifab mentioned this issue Mar 27, 2020
@unifab
Copy link
Contributor

unifab commented Mar 27, 2020

I attempted to fix the issue, the code is on the develop branch at https://github.com/DelacorLLC/vicompare
I initiated a pull request but I have no idea if the original code is still maintained by anybody.

@unifab
Copy link
Contributor

unifab commented Mar 27, 2020

By the way, SourceTree requires this code but https://git-fork.com/ doesn't. Configuring Git Fork is straightforward, I updated this blog post with how to configure Git Fork:
http://delacor.com/configuring-hg-or-git-to-use-labview-compare-and-labview-merge/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants