Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry provider implementation for micrometer #1087

Open
1 task
monosoul opened this issue May 2, 2024 · 4 comments 路 May be fixed by #1089
Open
1 task

Telemetry provider implementation for micrometer #1087

monosoul opened this issue May 2, 2024 · 4 comments 路 May be fixed by #1089
Labels
enhancement New feature or request

Comments

@monosoul
Copy link

monosoul commented May 2, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Describe the Feature

TelemetryProvider implementation to publish metrics using micrometer

Is your Feature Request related to a problem?

It would be great if alongside the OTel implementation, there was also a micrometer implementation. Unfortunately, there's no adapter from OTel API to micrometer, there's no way to use OTel telemetry provider with micrometer.

Proposed Solution

Provide TelemetryProvider implementation usable with micrometer

Describe alternatives you've considered

Additional Context

This is a duplicate of awslabs/aws-sdk-kotlin#1301, since I wasn't sure where it's better to create this issue. Feel free to close the one that's in the wrong place 馃檪

  • I may be able to implement this feature request
@monosoul monosoul added the enhancement New feature or request label May 2, 2024
@ianbotsf
Copy link
Contributor

ianbotsf commented May 2, 2024

@monosoul thanks for opening this feature request, Micrometer looks cool. We can't prioritize this just yet but we'll leave it open so others can 馃憤+1 it.

I see you've made some contributions to the Micrometer GH repository so you've clearly got some familiarity...if you'd like to contribute a pull request to enable this feature, please feel free!

The telemetry interfaces/implementations live in smithy-kotlin not aws-sdk-kotlin so I'll be closing the other issue you opened in favor of this one.

@monosoul
Copy link
Author

monosoul commented May 2, 2024

Hey @ianbotsf , I took a quick look at the API you have for telemetry providers and it seems like interfaces there are heavily influenced by OTel implementation. Not yet sure if I'll be able to introduce micrometer implementation without touching some of those interfaces, therefore I was hoping someone more familiar with the code base will take a look into that 馃槄
I might give it a try too tho 馃

@ianbotsf
Copy link
Contributor

ianbotsf commented May 2, 2024

Yes, those interfaces in telemetry-api are pretty much fixed and won't likely be changed. New implementations will have to conform themselves to those interfaces, ignoring the features they can't support, using extra configuration options/extensions to support features not modeled in the telemetry API, etc.

If you're an existing user of both the AWS SDK for Kotlin and Micrometer then you're likely in the best position to at least start on an implementation鈥攅ven one that's narrowly tailored to your specific use case. If it's generalizable enough then a PR might be warranted. Feel free to reach out with questions about the existing interfaces and the current implementation for OTel.

@monosoul monosoul linked a pull request May 2, 2024 that will close this issue
@monosoul
Copy link
Author

monosoul commented May 2, 2024

Okay, I hacked for a bit and this might work I think: #1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants