Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client details out of codegen-core's EnumGenerator #2327

Closed
jdisanti opened this issue Feb 8, 2023 · 0 comments · Fixed by #2334
Closed

Refactor client details out of codegen-core's EnumGenerator #2327

jdisanti opened this issue Feb 8, 2023 · 0 comments · Fixed by #2334

Comments

@jdisanti
Copy link
Collaborator

jdisanti commented Feb 8, 2023 •
edited

The core EnumGenerator has several client-specific details around unknown variants, which the ServerEnumGenerator overrides out. This code should be moved into codegen-client as a customization to EnumGenerator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor client/server logic out of EnumGenerator smithy-lang/smithy-rs
1 participant
@jdisanti