Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request ID dropped when response is invalid JSON/XML #2344

Open
jdisanti opened this issue Feb 10, 2023 · 1 comment
Open

Request ID dropped when response is invalid JSON/XML #2344

jdisanti opened this issue Feb 10, 2023 · 1 comment
Labels
bug Something isn't working sdk

Comments

@jdisanti
Copy link
Collaborator

If parsing the response fails due to invalid JSON/XML in the response body, then the request ID is lost due to the parsing error bubbling up without the request ID being set in the error metadata. There should be an error handler that catches all parsing errors and attaches appropriate error metadata.

@jdisanti jdisanti added bug Something isn't working sdk labels Feb 10, 2023
@Velfi
Copy link
Contributor

Velfi commented Feb 13, 2023

I have thoughts on this related to the future smithy interceptors update.

We're going to be adding lifecycle methods that hook into each step in the process of sending a request and receiving a response and method will be fallible. Because of this, we need to devise some holistic method of surfacing/classifying errors at different stages. I'm still investigating what this would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdk
Projects
None yet
Development

No branches or pull requests

2 participants