Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tracing events #371

Closed
10 tasks done
Tracked by #1692
rcoh opened this issue May 13, 2021 · 1 comment
Closed
10 tasks done
Tracked by #1692

Add more tracing events #371

rcoh opened this issue May 13, 2021 · 1 comment
Assignees
@jdisanti
Labels
client ops Improves our operations and release process sdk-ga
Milestone
SDK GA

Comments

@rcoh
Copy link
Collaborator

rcoh commented May 13, 2021 •
edited by jdisanti

  • request
  • request body
  • response
  • response body

Separately, we should also enable tracing inside of sigv4:

  • canonical request
  • string to sign

Event Stream messages should also have trace logging:

  • Event Stream receive Message
  • Event Stream send Message

Make spans consistent and useful:

  • Run with texray to visually observe spans. Make better span names and make them more useful
  • Improve overall debuggability with spans
@rcoh rcoh assigned ghost May 17, 2021
@rcoh
Copy link
Collaborator Author

rcoh commented May 18, 2021

don't need to do all of them, but adding a couple would be a good tour of the code

@jdisanti jdisanti assigned jdisanti and unassigned ghost May 19, 2021
@jdisanti jdisanti added this to This Week in AWS Rust SDK via automation May 19, 2021
@jdisanti jdisanti moved this from This Week to In progress in AWS Rust SDK May 19, 2021
@jdisanti jdisanti mentioned this issue May 20, 2021
Merged
@jdisanti jdisanti removed their assignment May 20, 2021
@jdisanti jdisanti mentioned this issue May 20, 2021
Closed
@jdisanti jdisanti removed this from In progress in AWS Rust SDK May 21, 2021
@jdisanti jdisanti added the ops Improves our operations and release process label Aug 26, 2021
@jdisanti jdisanti mentioned this issue Aug 31, 2022
Closed
28 tasks
@jdisanti jdisanti added this to the SDK GA milestone Sep 30, 2022
This was referenced Dec 1, 2022
Merged
Merged
@jdisanti jdisanti closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisanti jdisanti

Labels
client ops Improves our operations and release process sdk-ga
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
2 participants
@jdisanti @rcoh