Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to be able to set a max retention of history #112

Closed
gwleclerc opened this issue Jun 6, 2020 · 0 comments · Fixed by #114
Closed

Add an option to be able to set a max retention of history #112

gwleclerc opened this issue Jun 6, 2020 · 0 comments · Fixed by #114
Labels
feature-request New feature or request

Comments

@gwleclerc
Copy link
Collaborator

It could be great to be able to set the maximum number of messages we want to store by session

Why:
Using that we could be able to use smocker as à dev gateway without worrying that memory increases as calls are made.

How:
On each call we can compare the history size to the retention and remove the oldest one when len(history) > retention

@gwleclerc gwleclerc added the feature-request New feature or request label Jun 6, 2020
@gwleclerc gwleclerc linked a pull request Jun 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant