Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Deprecated selector in colorful-json/styles/colorful-json.less #4

Closed
vforge opened this issue Jan 10, 2017 · 4 comments
Closed

Deprecated selector in colorful-json/styles/colorful-json.less #4

vforge opened this issue Jan 10, 2017 · 4 comments

Comments

@vforge
Copy link

vforge commented Jan 10, 2017

In colorful-json/styles/colorful-json.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • atom-text-editor::shadow .meta.structure.dictionary.json:not(.value) > .string.quoted.double.json, atom-text-editor::shadow .meta.structure.dictionary.json:not(.value) > .string.quoted.double.json > .punctuation.definition.string.json => atom-text-editor.editor .syntax--meta.syntax--structure.syntax--dictionary.syntax--json:not(.value) > .syntax--string.syntax--quoted.syntax--double.syntax--json, atom-text-editor.editor .syntax--meta.syntax--structure.syntax--dictionary.syntax--json:not(.value) > .syntax--string.syntax--quoted.syntax--double.syntax--json > .syntax--punctuation.syntax--definition.syntax--string.syntax--json

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

@smockle
Copy link
Collaborator

smockle commented Jan 10, 2017

Thanks for opening this issue @vforge! More details are in this Atom PR: atom/atom#12903

@smockle
Copy link
Collaborator

smockle commented Jan 11, 2017

Interestingly, the suggested replacement in Atom’s deprecation window misses the :not(.value) => :not(.syntax--value)

@smockle
Copy link
Collaborator

smockle commented Jan 11, 2017

This should be fixed in version 1.1.0

@vforge
Copy link
Author

vforge commented Jan 11, 2017

Working as a charm. Thanks for being quick!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants