Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warp sync starting point should be a session change block #1486

Open
tomaka opened this issue Dec 18, 2023 · 0 comments
Open

Warp sync starting point should be a session change block #1486

tomaka opened this issue Dec 18, 2023 · 0 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Dec 18, 2023

When sending a warp sync request, if the target node has itself synced through a warp sync, it might not have finished downloading all blocks.

The only guarantee that we have is that it has finished downloading the header and justifications of blocks at session changes, since it had to download these for its warp sync.

Consequently, the block in a warp sync request must be a session change block.
Consequently, the checkpoint that we put in chain specs must be a session change block. Or, alternatively, the chain spec can contain both a session change block and a more recent block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant