New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move things around #194
Merged
Merged
Move things around #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way the |
twiggy diff reportDifference in .wasm size before and after this pull request.
|
tomaka
added a commit
to tomaka/smoldot
that referenced
this pull request
Feb 20, 2023
tomaka
added a commit
that referenced
this pull request
Feb 20, 2023
* Finish updating `wasm-node-size-diff` CI stage after #194 * Remove the TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relatively big but straight-forward.
It moves the
src
directory tolib/src
, and all the subdirectories ofbin
to the root. The chain specs have been moved to a new directory calleddemo-chain-specs
.I think that this "flat" layout of the various components of the project is better for the comprehension of people who aren't familiar with the source code.