Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move things around #194

Merged
merged 7 commits into from Feb 20, 2023
Merged

Move things around #194

merged 7 commits into from Feb 20, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 20, 2023

This PR is relatively big but straight-forward.

It moves the src directory to lib/src, and all the subdirectories of bin to the root. The chain specs have been moved to a new directory called demo-chain-specs.

I think that this "flat" layout of the various components of the project is better for the comprehension of people who aren't familiar with the source code.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 20, 2023

Due to the way the wasm-node-size-diff CI stage works (it checks out the base branch and compiles it), this change will be done in two steps. Another PR will be opened afterwards to remove one remaining /bin

@github-actions
Copy link

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
     +116100 ┊ smoldot_light::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h3cbce3d07acc0b17
     -116087 ┊ smoldot_light::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h3a82bcfadf92d7e8
      -50628 ┊ smoldot::executor::host::ReadyToRun::run_once::h69c3eb4e39dd0256
      +50628 ┊ smoldot::executor::host::ReadyToRun::run_once::h76e21e5c96aa7c73
      +47476 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hb7959edf5b312d9a
      -47476 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hbe96c6c6a940cf29
      +14067 ┊ <core::panic::unwind_safe::AssertUnwindSafe<F> as core::future::future::Future>::poll::h7afc65fb424d56c7
      -14067 ┊ <core::panic::unwind_safe::AssertUnwindSafe<F> as core::future::future::Future>::poll::h86fa42ec3e3eddf2
      +13152 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::h9c5b0124aca39e73
      -13152 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::hd30d281016c2bb33
      +13105 ┊ smoldot_light::transactions_service::background_task::{{closure}}::had59f353057e7953
      -13105 ┊ smoldot_light::transactions_service::background_task::{{closure}}::he4662f6f9d88e56f
      -11917 ┊ futures_util::abortable::Abortable<T>::try_poll::hc7d0a64e77f374e5
      +11909 ┊ futures_util::abortable::Abortable<T>::try_poll::h62d809c406b656fd
      +11514 ┊ smoldot_light::sync_service::standalone::start_standalone_chain::{{closure}}::h4c7d7be6cdd911bc
      -11514 ┊ smoldot_light::sync_service::standalone::start_standalone_chain::{{closure}}::hd992f2e22bc05c0d
      -11345 ┊ smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<TPlat>>::chain_head_call::{{closure}}::{{closure}}::h4655ddf19b521f9f
      +11345 ┊ smoldot_light::json_rpc_service::chain_head::<impl smoldot_light::json_rpc_service::Background<TPlat>>::chain_head_call::{{closure}}::{{closure}}::hd9114110c17955a2
      +10949 ┊ smoldot_light::Client<TPlat,TChain>::add_chain::h8b5fb75e86a4bbd0
      -10949 ┊ smoldot_light::Client<TPlat,TChain>::add_chain::hfab886f9c3a4d416
        +677 ┊ ... and 22987 more.
       +3070 ┊ Σ [23007 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 20, 2023
Merged via the queue into smol-dot:main with commit 165412f Feb 20, 2023
@tomaka tomaka deleted the move-things-around branch February 20, 2023 13:23
tomaka added a commit to tomaka/smoldot that referenced this pull request Feb 20, 2023
tomaka added a commit that referenced this pull request Feb 20, 2023
* Finish updating `wasm-node-size-diff` CI stage after #194

* Remove the TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant