Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the examples directory #72

Closed
ghost opened this issue May 2, 2020 · 2 comments
Closed

Rename the examples directory #72

ghost opened this issue May 2, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented May 2, 2020

I'm considering renaming the examples directory to something else, perhaps demos. I find two things about the current setup inconvenient:

  1. It's hard to add new examples because we need to add an [[example]] section per example to examples/Cargo.toml. I find this inconvenient because sometimes it's nice to add a quick temporary example for testing.

  2. You need to be in the examples directory to run examples.

A possible solution to this would be to:

  • rename examples to demo
  • delete autoexamples = false
  • add demo to default-members list in the [workspace] section
  • perhaps change examples to bins

In that case, we could do cargo run --bin ctrl-c from the root of the repository.

@tshepang
Copy link
Contributor

tshepang commented May 2, 2020

I can do this if you want... looks like easy way to contribute

@ghost
Copy link
Author

ghost commented May 2, 2020

@tshepang Go ahead! :)

@ghost ghost closed this as completed Jul 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant