Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken on master #378

Closed
Dirbaio opened this issue Sep 21, 2020 · 2 comments
Closed

Tests broken on master #378

Dirbaio opened this issue Sep 21, 2020 · 2 comments

Comments

@Dirbaio
Copy link
Member

Dirbaio commented Sep 21, 2020

It's due to changes in nightly.

Works with nightly-2020-08-17 rustc 1.47.0-nightly (7e6d6e5f5 2020-08-16)
Broken with nightly-2020-08-18 rustc 1.47.0-nightly (792c645ca 2020-08-17)

Travis doesn't have a fixed nightly version, this is why tests that passed before can break without changing anything in the code.

@Dirbaio
Copy link
Member Author

Dirbaio commented Sep 22, 2020

I'm pretty sure it's a Rust bug. This tiny test fails on the broken Rust versions:

    #[test]
    fn test_quash_psh() {
        assert_eq!(Control::Psh.quash_psh(), Control::None);
    }

Actually I just updated my nightly and it's fixed in 2020-09-19.

Seems to be this: rust-lang/rust#76803

@Dirbaio
Copy link
Member Author

Dirbaio commented Sep 22, 2020

Yep, I just pushed to #346 and tests are passing.

@Dirbaio Dirbaio closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant