Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack options sockPath, sockHost, and sockPort to get socket URL #42

Merged
merged 1 commit into from May 23, 2019

Conversation

mefu
Copy link
Contributor

@mefu mefu commented May 23, 2019

Hello,

This pull request fixes issue #41.

I looked at entry files of webpack-dev-server and webpack-hot-middleware to understand how can I pass variables to entry scripts.

Right now, I just check if ___resourceQuery exists, and parse it instead of this. It worked well in my tests of 3 considerably big and complex reactjs projects but I cannot claim that I've tested every possible webpack configuration.

If you provide feedback, I will implement it.

Thank you!

@gregberge gregberge merged commit b763f76 into gregberge:master May 23, 2019
@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants