resetBrowser

[UziTech]

Summary

Add jestPuppeteer.resetBrowser() function to reset the global.browser object according to the configuration.

global.browser is is setup based on the configuration.

this.global.browser = await puppeteer.connect({
  ...config.connect,
  ...config.launch,
  browserURL: undefined,
  browserWSEndpoint: wsEndpoint,
})

This will allow the browser to be reset by the user and ensure the global.browser object will be the same after this call as the when it was first setup.

Users can reset the global.browser object before each test by calling jestPuppeteer.resetBrowser() in a beforeEach function easily.

beforeEach(async () => {
  await jestPuppeteer.resetBrowser()
})

fixes #183 (comment)

Test plan

describe('resetBrowser', () => {
  test('should reset browser', async () => {
    const oldBrowser = browser
    await jestPuppeteer.resetBrowser()
    expect(browser).not.toBe(oldBrowser)
    // eslint-disable-next-line no-underscore-dangle
    expect(browser._connection._closed).toBe(false)
    // eslint-disable-next-line no-underscore-dangle
    expect(oldBrowser._connection._closed).toBe(true)
  })
})

[UziTech]

I'm not sure how to get the browser.closed state without using browser._connection._closed in the tests. It would be better if there was a browser.isClosed() function like on page but I don't think there is anything like that.

[xiaoyuhen]

hi @UziTech

thanks for your great work! I will take a look before this Sunday.

[UziTech]

puppeteer/puppeteer#4403 did get merged so there will be a browser.isConnected() function in the next release of puppeteer.

Should we wait to merge this until that is released? Or we could just change the test later.

[gregberge]

Hmm, we support also old versions of Puppeteer, so we should not rely on this method.

[UziTech]

That code is just in the test so we would just need to update puppeteer in devDependencies.

That code isn't crucial so I don't think it matters too much if we don't use .isConnected()

[gregberge]

@UziTech if it is only in test, then it is OK for me, do you know when will it be released?

[UziTech]

I updated puppeteer in devdependencies and use the new .isConnected() function in the test.

[gregberge]

It looks good, @xiaoyuhen are you OK with it?

[UziTech]

@xiaoyuhen @neoziro any progress on this?

[gregberge]

@xiaoyuhen seems to be absent. I will try to take time to test it next week.

[UziTech]

I fixed the spelling and rebased to fix the conflict.