Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call setRawMode if stdin is TTY #301

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Only call setRawMode if stdin is TTY #301

merged 1 commit into from
Dec 18, 2019

Conversation

fstanis
Copy link
Contributor

@fstanis fstanis commented Dec 14, 2019

Summary

stdin.setRawMode doesn't exist and throws if stdin is not TTY:

TypeError: stdin.setRawMode is not a function
  at node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:82:19
  at Object.debug (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:61:16)

@gregberge gregberge merged commit 61d04c7 into argos-ci:master Dec 18, 2019
@gregberge
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fstanis @gregberge