Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Object.is ponyfill to improve ie compatibility #371

Closed
wants to merge 1 commit into from
Closed

fix: add Object.is ponyfill to improve ie compatibility #371

wants to merge 1 commit into from

Conversation

NaccOll
Copy link

@NaccOll NaccOll commented Jun 30, 2019

Summary

use ponyfill to replace Object.is due to ie compatibility.

Test plan

➜  loadable-components git:(add-Object.is-ponyfill) ✗ yarn test
yarn run v1.16.0
$ jest
 PASS  packages/server/src/util.test.js
 PASS  packages/server/src/ChunkExtractor.test.js
 PASS  packages/component/src/loadable.test.js
 PASS  packages/babel-plugin/src/index.test.js

Test Suites: 4 passed, 4 total
Tests:       83 passed, 83 total
Snapshots:   55 passed, 55 total
Time:        3.961s
Ran all test suites.
Done in 5.60s.

@theKashey
Copy link
Collaborator

cacheKey is expected to be just a string. Do we even need Object.is comparison?

@NaccOll
Copy link
Author

NaccOll commented Jun 30, 2019

@theKashey I don't know the previous design. I found that starting from 5.10.0, I can't open the page after using this dependency in IE browser. So I submit the pr.

gregberge added a commit that referenced this pull request Jul 15, 2019
@gregberge
Copy link
Owner

Fixed in #392

@gregberge gregberge closed this Jul 15, 2019
@NaccOll NaccOll deleted the add-Object.is-ponyfill branch July 20, 2019 14:28
fivethreeo pushed a commit to fivethreeo/loadable-components that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants