fix(babel-plugin): fix usage of spread attribute(#231)

gregberge · Nov 13, 2018 · 4186953 · 4186953 · vercel · Nov 13, 2018
1 parent 56241b3
commit 4186953
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/babel-plugin-remove-jsx-attribute/src/index.js b/packages/babel-plugin-remove-jsx-attribute/src/index.js
@@ -4,7 +4,8 @@ const removeJSXAttribute = (api, opts) => ({
       if (!opts.elements.includes(path.node.name.name)) return
 
       path.get('attributes').forEach(attribute => {
-        if (opts.attributes.includes(attribute.node.name.name)) {
+        const nodeName = attribute.node.name;
+        if (nodeName && opts.attributes.includes(nodeName.name)) {
           attribute.remove()
         }
       })

diff --git a/packages/babel-plugin-remove-jsx-attribute/src/index.test.js b/packages/babel-plugin-remove-jsx-attribute/src/index.test.js
@@ -19,4 +19,13 @@ describe('plugin', () => {
       }),
     ).toMatchInlineSnapshot(`"<div foo><span /></div>;"`)
   })
+
+  it('should not throw error when spread operator is used', () => {
+    expect(
+      testPlugin('<div foo><span foo {...props} /></div>', {
+        elements: ['span'],
+        attributes: ['foo'],
+      }),
+    ).toMatchInlineSnapshot(`"<div foo><span {...props} /></div>;"`)
+  })
 })