Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward filename to SVGO #188

Closed
gregberge opened this issue Sep 26, 2018 · 2 comments
Closed

Forward filename to SVGO #188

gregberge opened this issue Sep 26, 2018 · 2 comments
Labels
bug 🐛 WIP ⏳

Comments

@gregberge
Copy link
Owner

As discussed in #152, filename is required for some SVGO plugin, actually SVGR webpack loader and Rollup plugin are not passing it. We need to modify these plugin to make it work correctly with SVGO.
This was referenced Sep 26, 2018
Closed
Closed
gregberge added a commit that referenced this issue Sep 30, 2018
@gregberge
fix(rollup): forward filePath in rollup plugin
461492b 
This will fix all SVGO issues.

BREAKING CHANGE: runtime configuration is now loaded using rollup plugin.

Fixes #177
Fixes #188
@tremby
Copy link

tremby commented Oct 1, 2018

This works great in the context of #152. Thanks!

@gregberge
Copy link
Owner Author

Awesome 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 WIP ⏳
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tremby @gregberge