Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding preflight component to emotion #167

Merged
merged 3 commits into from
Jan 10, 2021
Merged

feature: adding preflight component to emotion #167

merged 3 commits into from
Jan 10, 2021

Conversation

marceloadsj
Copy link
Contributor

Summary

The xstyled/emotion does not provide a Preflight component, like the xstyled/styled-components do.

Now we have a Preflight exported from xstyled/emotion. It utilizes the component from emotion (https://emotion.sh/docs/globals).

Test plan

Created two tests, basically:

  1. Make sure the Preflight component renders null (as, on client, it injects into the DOM)
  2. Make sure the Preflight component inject styles into the DOM.

@marceloadsj marceloadsj changed the title Feat/adding preflight to emotion feature: adding preflight component to emotion Jan 10, 2021
@marceloadsj
Copy link
Contributor Author

I will check why the build failed soon, so, we should consider this PR as WIP for now.

@marceloadsj
Copy link
Contributor Author

Fixed :)

@gregberge gregberge merged commit b56e6b6 into styled-components:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants