bugfix: size 0.5 conflict fluid range #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloadsj
changed the title
gregberge
approved these changes
Jan 10, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #162
Any size key between 0 and 1 should have a suffix "s" so it does not conflict with fluid (%) values.
This PR adds a suffix "s" to size key 0.5 on theme so it can be targeted without conflicting with fluid (50%).
I've improved the explanation on the docs of why the suffix "s" have be used.
Test plan
Added a test to check if all numeric keys of theme sizes are greater than 1.