unsuccessful upload does not raise exception

[danmilon]

import tinys3

conn = tinys3.Connection(S3_ACCESS_KEY,S3_SECRET_KEY,tls=True)

f = open('some_file.zip','rb')
conn.upload('some_file.zip',f,'my_bucket')

The bucket resides in the eu-west-1 region. The code above completes successfully, but here's the HTTP communication:

PUT /my-backet/some_file.zip HTTP/1.1

Host: s3.amazonaws.com
Date: Wed, 30 Apr 2014 10:36:02 GMT
Accept: */*
Content-Length: 4151
Authorization: [...]
x-amz-acl: public-read
User-Agent: python-requests/2.2.1 CPython/3.4.0 Linux/3.14.1-1-ARCH
Content-Type: application/vnd.openxmlformats-officedocument.wordprocessingml.document
Accept-Encoding: gzip, deflate, compress

HTTP/1.1 301 Moved Permanently

x-amz-request-id: [...]
x-amz-id-2: [...]
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 30 Apr 2014 10:35:50 GMT
Connection: close
Server: AmazonS3

1d3
<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>PermanentRedirect</Code><Message>The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.</Message><RequestId>[...]</RequestId><Bucket>my-bucket</Bucket><HostId>[...]</HostId><Endpoint>my-bucket.s3.amazonaws.com</Endpoint></Error>
0

I noticed raise_for_status() is called, but I suppose 301 is not considered an error, thus no exception is raised.

I know I should provide the endpoint to tinys3 but I believe the code should check explicitly for status >= 300 and raise accordingly in order to avoid silently failing requests.

@shlomiatar, what do you think?