Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multipart uploads #21

Open
Scylardor opened this issue Jun 19, 2014 · 2 comments
Open

Support for multipart uploads #21

Scylardor opened this issue Jun 19, 2014 · 2 comments

Comments

@Scylardor
Copy link
Contributor

Hi,
I'm currently porting an application using boto to Python 3 and I'd like to use tinys3 instead of boto for it (as boto isn't ready for python 3).

The problem is that it makes heavy use of S3 multipart uploads and tinys3 doesn't seem like it's going to feature it in the near future.

So I'm going to fork the repo and try to implement multipart uploads myself (I need it ASAP). If that works well I may do a pull request. Just so you know. :)

@shlomiatar
Copy link
Contributor

Awesome :) Let me know when it's ready! :)

@Scylardor
Copy link
Contributor Author

Hi Shlomi,

I've been pretty busy since last time but I think I've nearly finished. Multipart uploads are implemented. As my application used Boto, I use a MultipartUpload object quite like the Boto one, and it works great so far ! For what I use them, at least.

On the other hand, I saw that the ListRequest pull request has been merged since then. In fact I had to do the same thing for keys, multipart uploads, and parts of an upload. But I'm going to need a bit of extra time to adapt my code to the most recent version of your repo, because I like the way it is done in ListRequest, it is smarter than what I did (with a kind of all-purpose HTMLParser) so I'll change the way I parse responses in all my "listing" functions.

I'll make the pull request when I'll be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants