Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static_proxy. #59

Merged
merged 3 commits into from Sep 5, 2022
Merged

feat: static_proxy. #59

merged 3 commits into from Sep 5, 2022

Conversation

skykaka
Copy link
Contributor

@skykaka skykaka commented Aug 21, 2022

Generate static proxy for mapper class for the user can use the mapper without the mapper object.

Which is discussed at #57 (comment).

Generate static proxy for mapper class for the user can use the mapper without the mapper object.
@smotastic
Copy link
Owner

Hi @skykaka
Thank you for the contribution,
As discussed I like the idea, so I'll make sure to check it out on the weekend

@skykaka
Copy link
Contributor Author

skykaka commented Sep 2, 2022

Hi @smotastic
The code is not reviewed. Have you been busy recently, or is there some problem?

Copy link
Owner

@smotastic smotastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry I couldn't check the changes out last week. As you assumed I was very busy. But I like the change overall, just one small suggestion in the code.

smartstruct/lib/src/annotations.dart Outdated Show resolved Hide resolved
@skykaka
Copy link
Contributor Author

skykaka commented Sep 4, 2022

Hi @smotastic
Very import suggestion. The name "static" is so arbitrary. I haven't thought enough about this. The name  'generateStaticProxy' is good enough. It's very clear. I think we'd better use this name. I will finish the modification of the code in the next few days.

@smotastic smotastic merged commit 26e1a0d into smotastic:develop Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants