Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise support #60

Closed
msfidelis opened this issue Oct 11, 2017 · 6 comments
Closed

Promise support #60

msfidelis opened this issue Oct 11, 2017 · 6 comments
Assignees

Comments

@msfidelis
Copy link

I needed to migrate from some services using Amazon SQS applications to the Redis queues. I wrote this interface to solve rsmq like a promises.

This is necessary in several cases on my microservices and lambda functions. Is it possible to add this into rsmq core?

https://github.com/msfidelis/rsmq-promise

@smrchy
Copy link
Owner

smrchy commented Oct 12, 2017

While there are plans to do a full rewrite of RSMQ i currently lack the time to start.

In the meantime i will link to your project from the README file.

@smrchy smrchy self-assigned this Oct 12, 2017
@msfidelis
Copy link
Author

That's ok for me! 😄

@smrchy smrchy closed this as completed in de41baa Oct 18, 2017
@overflowz
Copy link

You did great work, @msfidelis but having support in core library would be much cooler IMO, since you have to stay up-to-date when new features are coming for RSMQ library itself. e.g. I saw PR & comment on rsmq-promise repo to update version to latest but there is still no response from you tho. Instead, I have to use bluebird to promisify rsmq prototype (I really needed realtime support).

@erdii erdii assigned erdii and unassigned smrchy Jan 11, 2019
@erdii
Copy link
Contributor

erdii commented Jan 11, 2019

Will take care of that next week!

@erdii erdii reopened this Jan 11, 2019
@erdii
Copy link
Contributor

erdii commented Jan 11, 2019

Promise support has been added in 6fd5036. If tests pass, we will build and release a new version next week.

@erdii
Copy link
Contributor

erdii commented Jan 14, 2019

Wohoo! Promise support has landed in rsmq@0.10.0! Use receiveMessageAsync instead of receiveMessage (works for all queue methods, typings included) and everything should work as intended.

Feedback will be appreciated! 😊

@erdii erdii closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants