Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise detection of data and svg names #1058

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: optimise detection of data and svg names #1058

merged 1 commit into from
Oct 25, 2023

Conversation

iambumblehead
Copy link
Contributor

per #1057, use startsWith to optimise the detection of data and svg names

this PR would satisfy two outstanding PRs

  1. fix: optimization judge node attribute #1037, optimize data attribute
  2. fix: optimization judge svg #1033, optimize svg selector

@paldepind
Copy link
Member

Thanks for the PR @iambumblehead and especially for the benchmark which shows that this is in fact an optimization.

The only "downside" to this is that it doesn't work in Internet Explorer. But at this point, I don't think we have to worry about that anymore.

@paldepind paldepind merged commit 71813ff into snabbdom:master Oct 25, 2023
1 check passed
@iambumblehead iambumblehead deleted the use-startsWith-test branch October 25, 2023 21:48
@iambumblehead
Copy link
Contributor Author

thank you @paldepind if I am useful that makes me happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants