Detect opportunity to insert new vnode earlier for more efficient DOM manipulation #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t DOM manipulation ISSUES CLOSED: #1099
paldepind
commented
Jan 30, 2024
| insertCount++; | ||
| htmlDomApi.insertBefore(a, b, c); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This change has no effect on the resulting DOM, only on the process by which we get there. Hence the test wraps the htmlDomApi to be able to observe what goes on in there.
paldepind
commented
Jan 30, 2024
| @@ -837,6 +838,44 @@ describe("snabbdom", function () { | |||
| assert.equal(elm.children[1].innerHTML, "symbol"); | |||
| assert.equal(elm.children[2].innerHTML, "symbol"); | |||
| }); | |||
| it("simultaneous addition in beginning and removal in end", function () { | |||
There was a problem hiding this comment.
This test also passed before this PR. I'm adding it for symmetry with the test below and to make sure that the non-inefficent case reported in #1099 is now tested.
Closed
paldepind
commented
Jan 30, 2024
| @@ -49,7 +49,7 @@ function isDocumentFragment( | |||
| return api.isDocumentFragment!(vnode as any); | |||
| } | |||
|
|
|||
| type KeyToIndexMap = { [key: string]: number }; | |||
There was a problem hiding this comment.
This is unrelated to the PR but I just happened to improve this type as well.
paldepind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the child reordering patch process slightly. Before beginning to move elements around we add an extra case where we check if the end of the new remaining vnodes is brand new and could thus be handled by inserting a new DOM node.
This should address and close #1099.