Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube ReVanced module isn't working. #15

Closed
Edgars-Cirulis opened this issue Apr 25, 2024 · 5 comments
Closed

Youtube ReVanced module isn't working. #15

Edgars-Cirulis opened this issue Apr 25, 2024 · 5 comments

Comments

@Edgars-Cirulis
Copy link

Edgars-Cirulis commented Apr 25, 2024

Hello,

I am writing to inform you that the YouTube ReVanced module is not functioning with the most recent update, version 2.1.0. As a result, I was forced to downgrade to an earlier version in order to continue using the module.

@snake-4
Copy link
Owner

snake-4 commented Apr 25, 2024

The YouTube app and ReVanced Manager has to be whitelisted in order to "see" the modifications of ReVanced. On KSU disable unmount and on Magisk remove it from the denylist.

See this is the intended behavior, it will hide the modifications unless you whitelist the apps.

@Edgars-Cirulis
Copy link
Author

I am using KernelSU and not using any ReVanced Managers, just an module by j-hc https://github.com/j-hc/revanced-magisk-module There is no whitelist for sure, also disable unmount there's no option like that either, I see only unmout modules by default but it's checked on because it makes more sense by reading the description

@snake-4
Copy link
Owner

snake-4 commented Apr 25, 2024

Unmount modules has to be disabled on YT app for it to work. Otherwise it unmounts your ReVanced module from YT.

@snake-4 snake-4 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
@Edgars-Cirulis
Copy link
Author

Unmount modules has to be disabled on YT app for it to work. Otherwise it unmounts your ReVanced module from YT.

By default "Unmount modules" is enabled on KSU, without this Zygisk Assistant module YouTube ReVanced works completely fine.

@snake-4
Copy link
Owner

snake-4 commented Apr 25, 2024

Unmount modules has to be disabled on YT app for it to work. Otherwise it unmounts your ReVanced module from YT.

By default "Unmount modules" is enabled on KSU, without this Zygisk Assistant module YouTube ReVanced works completely fine.

https://kernelsu.org/guide/app-profile.html#umount-modules

See the link above for the purpose of that option. This module uses the value of that option to determine whether to unmount the modules or not.

If your kernel is not GKI and KSU was improperly ported, then it won't have an effect at all by itself.

Again, it is by design. If we did not unmount the modules for apps that have the option enabled, then apps that check for root would easily detect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants