Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wildcards in comment string #85 #88

Merged
merged 9 commits into from
May 6, 2024
Merged

Conversation

mrvollger
Copy link
Contributor

@mrvollger mrvollger commented May 6, 2024

Small change to include wildcards in the comment strings (re #85).

I tested it locally on my Slurm instance, and it works well.

I also prefixed the rule name with rule_ to match the formatting of the slurm log path.

Cheers,
Mitchell

@cmeesters cmeesters changed the title Wildcards in comment string #85 feat: wildcards in comment string #85 May 6, 2024
Copy link
Collaborator

@cmeesters cmeesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine - let's try it

@cmeesters cmeesters merged commit 730cac0 into snakemake:main May 6, 2024
4 of 5 checks passed
cmeesters pushed a commit that referenced this pull request May 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.5...v0.5.0)
(2024-05-06)


### Features

* wildcards in comment string
[#85](#85)
([#88](#88))
([730cac0](730cac0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants