New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'active' class is only applied when liveSearch is on #1110
Comments
This is intentional. When a select doesn't have liveSearch enabled, the selected option is focused. When liveSearch is enabled, the When bootstrap-select was first released, the liveSearch option didn't exist, so this is a remnant to keep "normal" selects (without liveSearch enabled) consistent with older versions of bootstrap-select. However, at this point, it would probably make more sense to always apply the |
Ah yup, I understand what you're saying. I just think it should be consistent either way. In my case I'm activating liveSearch on my selects when they have more than a certain number of options, which means they can change from time to time if the number of options changes. The difference in appearance confused me for a long time until I tracked down what the cause was. A possibly related issue: When using the liveSearch (i.e. typing in it) there's no longer anything to indicate the currently selected item, even if you delete what you've typed and the whole menu returns (this isn't an issue with multiple selects as the tick mark is persistent). In practice it isn't really a big deal but just thought I'd mention it. |
I agree with you @caseyjhol! We should keep the coherency in both cases. Although, I think that we should keep the focus on the input of liveSearch when the dropdown is open. If we just change the |
Same. We've had liveSearch for a while now, so I think we should be fine to replace the old behaviour with a consistent one. |
Same issue here |
Available in v1.13.0-alpha. |
I am getting .active on bs-select element on initialization, even if it was not touched. is this expected? |
On a non-multiple select, the selected li in the dropdown menu is given the class 'active' (which highlights it blue) if and only if liveSearch is on. Not sure if this is a bug or intentional but I would think the 'active' class should be applied regardless of search.
The text was updated successfully, but these errors were encountered: