Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 2.3.0 #50

Closed
t3chn0r opened this issue Feb 8, 2013 · 5 comments
Closed

Bootstrap 2.3.0 #50

t3chn0r opened this issue Feb 8, 2013 · 5 comments
Labels

Comments

@t3chn0r
Copy link

t3chn0r commented Feb 8, 2013

Just did some quick tests with 2.3.0 and noticed the lost of the format for the options. Checking the new .css file it seems like Bootstrap changed the selector from ".dropdown-menu li > a" to ".dropdown-menu > li > a", this selector doesn't work because there's a

    element between .dropdown-menu and
  • . I already opened an issue here in Github in the Bootstrap repo.

    If you want to have the old behavior just add the following lines to your bootstrap-select.css:

    .bootstrap-select.btn-group .dropdown-menu li > a {
        display: block;
        padding: 3px 20px;
        clear: both;
        font-weight: normal;
        line-height: 20px;
        color: #333333;
        white-space: nowrap;
    }
    .bootstrap-select.btn-group .dropdown-menu li > a:hover, .bootstrap-select.btn-group .dropdown-menu li > a:focus {
        text-decoration: none;
        color: #ffffff;
        background-color: #0081c2;
        background-image: -moz-linear-gradient(top, #0088cc, #0077b3);
        background-image: -webkit-gradient(linear, 0 0, 0 100%, from(#0088cc), to(#0077b3));
        background-image: -webkit-linear-gradient(top, #0088cc, #0077b3);
        background-image: -o-linear-gradient(top, #0088cc, #0077b3);
        background-image: linear-gradient(to bottom, #0088cc, #0077b3);
        background-repeat: repeat-x;
        filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff0088cc', endColorstr='#ff0077b3', GradientType=0);
    }
    
@t3chn0r
Copy link
Author

t3chn0r commented Feb 8, 2013

Just what I thought after posting the issue to Bootstrap. It seems bootstrap-select is adding the dropdown-menu class to the <div> instead of the <ul> element...

@silviomoreto
Copy link
Collaborator

Tnks @t3chn0r . Please add the link of the issue you opened in bootstrap repo.

Until they don't answer your issue I will add this code to the css file

@t3chn0r
Copy link
Author

t3chn0r commented Feb 13, 2013

Hello @silviomoreto, actually they responded and exactly about the

@silviomoreto
Copy link
Collaborator

Ok, I will change the components

@silviomoreto silviomoreto reopened this Feb 13, 2013
@caseyjhol
Copy link
Member

I initially wrapped the ul in a div for the data-size feature to work (so the scrollbar looks good). I haven't looked at that part of the code in a while, but I'm sure it wouldn't take much to get it to work without it. I'll try to get around to it this week to return to default bootstrap markup.

caseyjhol added a commit that referenced this issue Feb 20, 2013
Fix #50 and add #60 (disabled options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants