Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the API (internal & external) #671

Closed
1 task done
t0xicCode opened this issue Aug 3, 2014 · 1 comment
Closed
1 task done

Update the API (internal & external) #671

t0xicCode opened this issue Aug 3, 2014 · 1 comment
Assignees
Milestone

Comments

@t0xicCode
Copy link
Collaborator

Currently, both public methods and private methods are exposed and follow the same API guidelines.

In a commitment to semver, I propose for the 2.0 release, to update the API as follow:

  • All public methods are assigned to an instance variable in the Selectpicker object
  • All private methods follow the convention of starting with an underscore
  • Implement the noConflict API
@t0xicCode t0xicCode added this to the ng milestone Aug 3, 2014
@t0xicCode t0xicCode self-assigned this Aug 3, 2014
@t0xicCode
Copy link
Collaborator Author

I've reconsidered the position. At this point, we'll keep the API as is. If a method is documented on the documentation pages, the API is considered stable. All undocumented methods are subject to change within minor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant