core: classic with no exported variables. #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the use of environment variables as they leak into whatever else calls them. This helps classic confinement but also other things like snaps with python2 and python3 parts. LP: #1657504 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
To avoid unexpected errors we wipe clean the envrionment variables inside the wrappers, if a developer needs it they could export it themselves. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
bugfix/classic-env-vars
branch
from
7a26a3d
to
7d44e14
Compare
Current coverage is 96.31% (diff: 85.96%)@@ master #1090 diff @@
==========================================
Files 194 194
Lines 17775 17806 +31
Methods 0 0
Messages 0 0
Branches 1371 1375 +4
==========================================
+ Hits 17126 17150 +24
- Misses 440 444 +4
- Partials 209 212 +3
|
|
Might be replace with #1093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid unexpected errors we wipe clean the envrionment
variables inside the wrappers, if a developer needs it
they could export it themselves.
LP: #1657504
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com