Remove Unicode quotes from help text #373
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@snappy-m-o you're a bit over-zealous. @ssweeny ugh, thank you for tracking those down! This looks good. |
|
I wonder if we can come up with a test that would prevent unicode characters from sneaking into the help text in the future? |
|
Have a python script try to print out all the module help text in the source tree? 😉 |
|
Ah, let me rephrase. Hey @ssweeny, mind adding a test to this PR to make sure unicode characters can't sneak back into the help text? |
|
@kyrofa yeah I can give it a shot this weekend. |
|
👍 |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
OK to test |
|
I'm not sure why the three comments. We have to jobs, so it might make sense to have two comments. Three is jjust nonsense. Instead of two jobs we could have one job that triggers these two, we will be checking into it now that we need a workflow plugin for snappy. |
|
Excellent job @ssweeny, thank you! Please squash up, then I'm good with this 👍 . |
|
@ElOpio autopkgtest "No test results found" = "Success" ? |
ssweeny
force-pushed
the
badunicode
branch
2 times, most recently
from
aa4b3c2
to
0e742e4
Compare
Help text has Unicode quotes in a few places, which breaks help output. This change replaces them with ASCII quotes Also add a test which checks the output of "snapcraft --help", "snapcraft help topics", "snapcraft help sources", "snapcraft help plugins" and "snapcraft help <PLUGIN>" for each plugin to make sure they don't contain non-ASCII characters which would break the help output when run normally LP: #1555733
|
As best I can tell the examples test failed due to a bad download. Is there a way to re-run it? |
|
retest this please |
|
@kyrofa I'm not sure what to collect as results of the autopkgtest. I'll check if I can change the message. |
|
This is good as is; landing |
Remove Unicode quotes from help text
Remove Unicode quotes from help text
Help text has Unicode quotes in a few places, which breaks help output as noted in https://bugs.launchpad.net/snapcraft/+bug/1555733. This change replaces them with ASCII quotes