Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update HACKING.md to recurse submodules #4006

Merged
merged 1 commit into from Jan 6, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Dec 16, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

A minor HACKING.md update requested by @giusebar.

I recently added snapd-testing-tools as a submodule. This submodule is required for running spread tests, so now I've updated the hacking instructions.

Additionally, broaden the note about using Ubuntu 16.04 LTS to any LTS.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #4006 (c638c18) into main (31a3990) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4006      +/-   ##
==========================================
+ Coverage   90.99%   91.61%   +0.61%     
==========================================
  Files          56       77      +21     
  Lines        4154     5153     +999     
==========================================
+ Hits         3780     4721     +941     
- Misses        374      432      +58     
Impacted Files Coverage Δ
snapcraft/__init__.py 72.72% <0.00%> (ø)
snapcraft/plugins/v2/__init__.py 0.00% <0.00%> (ø)
snapcraft/commands/__init__.py 100.00% <0.00%> (ø)
snapcraft/parts/plugins/__init__.py 100.00% <0.00%> (ø)
snapcraft/errors.py 91.17% <0.00%> (ø)
snapcraft/ua_manager.py 96.38% <0.00%> (ø)
snapcraft/plugins/v1/__init__.py 0.00% <0.00%> (ø)
snapcraft/store/__init__.py 100.00% <0.00%> (ø)
snapcraft/repo/__init__.py 100.00% <0.00%> (ø)
snapcraft/repo/apt_sources_manager.py 94.73% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 6, 2023

Failing ruby and flutter spread tests on core18 are unrelated. Merging.

@mr-cal mr-cal merged commit db9984a into canonical:main Jan 6, 2023
@mr-cal mr-cal deleted the readme-update branch January 6, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants