store: implement push pre-check. #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.34% (diff: 84.21%)@@ master #1009 diff @@
==========================================
Files 194 194
Lines 17251 17286 +35
Methods 0 0
Messages 0 0
Branches 1338 1339 +1
==========================================
+ Hits 16625 16654 +29
- Misses 425 431 +6
Partials 201 201
|
kyrofa
reviewed
Dec 20, 2016
| snap_yaml = _get_data_from_snap_file(snap_filename) | ||
| snap_name = snap_yaml['name'] | ||
| store = storeapi.StoreClient() | ||
|
|
||
| with _requires_login(): | ||
| store.push_precheck(snap_name) |
There was a problem hiding this comment.
Does this step take any significant amount of time? Should a message be printed about what it's doing in case it hangs at all?
There was a problem hiding this comment.
or do this after logging the message for which I want to change anyways ;-)
|
@kyrofa It does require an http request, which could potentially timeout if there's
an issue with the store. Logging something might be useful, but I'm not
sure what the best way to convey what the 'precheck' is for to the user.
Any suggestions? Maybe "Checking snap status in store..."?
…On Wed, 21 Dec 2016 at 5:27 AM, Kyle Fazzari ***@***.***> wrote:
***@***.**** commented on this pull request.
This looks good, just a quick question.
------------------------------
In snapcraft/_store.py
<#1009 (review)>
:
> snap_yaml = _get_data_from_snap_file(snap_filename)
snap_name = snap_yaml['name']
store = storeapi.StoreClient()
+
+ with _requires_login():
+ store.push_precheck(snap_name)
Does this step take any significant amount of time? Should a message be
printed about what it's doing in case it hangs at all?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1009 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH87oWCV3tpOUpsgdACn2kizy4RbT-Fks5rKAILgaJpZM4LRdZu>
.
|
Yeah that's fine, or even as opaque as "Checking with the store..." would be fine. The reason here is I think twofold:
|
sergiusens
reviewed
Jan 3, 2017
| with _requires_login(): | ||
| store.push_precheck(snap_name) | ||
|
|
||
| logger.info('Uploading {}.'.format(snap_filename)) |
There was a problem hiding this comment.
can we take the opportunity to call change this to 'Pushing {!r}'?
LP: #1610776
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
push-precheck
branch
from
b69f4f0
to
62ccccd
Compare
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
LP: #1610776 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #1610776
This branch adds a precheck request to the store to
snapcraft push, which in the case of an unregistered snap will report the error to the user before attempting a full upload.