Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdocs: update deprecation links #1048

Conversation

sergiusens
Copy link
Collaborator

LP: #1656265

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

LP: #1656265

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

Current coverage is 96.36% (diff: 100%)

Merging #1048 into master will not change coverage

@@             master      #1048   diff @@
==========================================
  Files           194        194          
  Lines         17324      17324          
  Methods           0          0          
  Messages          0          0          
  Branches       1340       1340          
==========================================
  Hits          16694      16694          
  Misses          430        430          
  Partials        200        200          

Powered by Codecov. Last update c949d5f...6242dc2

@sergiusens sergiusens merged commit bfd896a into canonical:master Jan 13, 2017
@sergiusens sergiusens deleted the bugfix/1656265/documentation-for-deprecations branch January 13, 2017 11:51
@@ -45,8 +45,8 @@ def test_snap_filter_is_deprecated(self):
self.assertThat(
output, Contains(
"DEPRECATED: The 'snap' keyword has been replaced by 'prime'."
"\nSee https://github.com/snapcore/snapcraft/wiki/Deprecation-"
"Notices#dn1 for more information."))
"\nSee http://snapcraft.io/docs/deprecation-notices/dn1 "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we update these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why was snapd added as a submodule?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
LP: #1656265

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants