New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustup link. Bug: 1662960 #1120
Conversation
thanks for this but mind fixing the tests? If you do it today it will get into |
Yeah I'm working on them now.
…On Wed, Feb 8, 2017 at 10:54 AM, Sergio Schvezov ***@***.***> wrote:
thanks for this but mind fixing the tests? If you do it today it will get
into 2.27
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1120 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC6qE0AlSZlNlAMUxY5FVX33mq6V84Dnks5rag98gaJpZM4L7Fms>
.
|
@sergiusens I think this should fix it up |
i am seeing things like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, this one supports aarch64!
Do you know where is the git repository for this script?
@ElOpio I do. It's here: https://github.com/rust-lang-nursery/rustup.rs :) |
Rustup has changed over to a new location .
@ElOpio @cholcombe973 reading the script it still doesn't support 64 bit kernels on 32 bit user spaces |
Ah crap I broke a bunch of things. This new rustup script doesn't act like the previous one. Let me work this out. |
I think i need to abandon this change. The new rustup is significantly different from the old one and it no longer supports an install prefix. |
should we close this or re-evaluate. I suppose we can propose fixes upstream. They reviewed my stuff pretty quick last time. |
Yeah I think we should close this for now. I'll try to work with upstream
to get things fixed before proposing a new PR
…On Thu, Feb 9, 2017 at 4:18 AM, Sergio Schvezov ***@***.***> wrote:
should we close this or re-evaluate. I suppose we can propose fixes
upstream. They reviewed my stuff pretty quick last time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1120 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC6qE-ZAXE1PYqu1XDs8MRFiz4sCUbzzks5rawQDgaJpZM4L7Fms>
.
|
Alright, closing for now. |
Rustup has changed over to a new location .
Thanks for helping us make a better Snapcraft!
Checklist:
LP: 1662960