Update rustup link. Bug: 1662960 #1120

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Rustup has changed over to a new location .

Thanks for helping us make a better Snapcraft!

Checklist:

  • Have you signed the contributor licence agreement? Yes
    LP: 1662960
  • Have you read our contribution guide? Yes
Collaborator

sergiusens commented Feb 8, 2017

thanks for this but mind fixing the tests? If you do it today it will get into 2.27

@sergiusens I think this should fix it up

Collaborator

sergiusens commented Feb 8, 2017

i am seeing things like
Expected: [call(['/tmp/tmp_345efam/parts/test-part/rust/sh.rustup.rs', '--prefix=/tmp/tmp_345efam/parts/test-part/rust', '--disable-sudo', '--save', '--channel=nightly']), call(['/tmp/tmp_345efam/parts/test-part/rust/bin/cargo', 'fetch', '--manifest-path', '/tmp/tmp_345efam/parts/test-part/src/Cargo.toml'])]
Actual: [call(['/tmp/tmp_345efam/parts/test-part/rust/rustup.sh', '--prefix=/tmp/tmp_345efam/parts/test-part/rust', '--disable-sudo', '--save', '--channel=nightly']),
call(['/tmp/tmp_345efam/parts/test-part/rust/bin/cargo', 'fetch', '--manifest-path', '/tmp/tmp_345efam/parts/test-part/src/Cargo.toml'])]

wow, this one supports aarch64!
Do you know where is the git repository for this script?

Update rustup link
Rustup has changed over to a new location .
Collaborator

sergiusens commented Feb 8, 2017

@elopio @cholcombe973 reading the script it still doesn't support 64 bit kernels on 32 bit user spaces

Ah crap I broke a bunch of things. This new rustup script doesn't act like the previous one. Let me work this out.

I think i need to abandon this change. The new rustup is significantly different from the old one and it no longer supports an install prefix.

it doesn't work :-)

Collaborator

sergiusens commented Feb 9, 2017

should we close this or re-evaluate. I suppose we can propose fixes upstream. They reviewed my stuff pretty quick last time.

Member

kyrofa commented Feb 10, 2017

Alright, closing for now.

@kyrofa kyrofa closed this Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment