Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update rustup link. Bug: 1662960 #1120
Conversation
|
thanks for this but mind fixing the tests? If you do it today it will get into |
cholcombe973
commented
Feb 8, 2017
|
Yeah I'm working on them now.
…
|
cholcombe973
commented
Feb 8, 2017
|
@sergiusens I think this should fix it up |
|
i am seeing things like |
elopio
reviewed
Feb 8, 2017
wow, this one supports aarch64!
Do you know where is the git repository for this script?
cholcombe973
commented
Feb 8, 2017
|
@elopio I do. It's here: https://github.com/rust-lang-nursery/rustup.rs :) |
|
@elopio @cholcombe973 reading the script it still doesn't support 64 bit kernels on 32 bit user spaces |
cholcombe973
commented
Feb 8, 2017
|
Ah crap I broke a bunch of things. This new rustup script doesn't act like the previous one. Let me work this out. |
cholcombe973
commented
Feb 8, 2017
|
I think i need to abandon this change. The new rustup is significantly different from the old one and it no longer supports an install prefix. |
sergiusens
dismissed
elopio’s
stale review
Feb 9, 2017
it doesn't work :-)
|
should we close this or re-evaluate. I suppose we can propose fixes upstream. They reviewed my stuff pretty quick last time. |
cholcombe973
commented
Feb 9, 2017
|
Yeah I think we should close this for now. I'll try to work with upstream
to get things fixed before proposing a new PR
…
|
|
Alright, closing for now. |
cholcombe973 commentedFeb 8, 2017
Rustup has changed over to a new location .
Thanks for helping us make a better Snapcraft!
Checklist:
LP: 1662960