Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustup link. Bug: 1662960 #1120

Closed
wants to merge 1 commit into from

Conversation

cholcombe973
Copy link

Rustup has changed over to a new location .

Thanks for helping us make a better Snapcraft!

Checklist:

  • Have you signed the contributor licence agreement? Yes
    LP: 1662960
  • Have you read our contribution guide? Yes

@sergiusens
Copy link
Collaborator

thanks for this but mind fixing the tests? If you do it today it will get into 2.27

@cholcombe973
Copy link
Author

cholcombe973 commented Feb 8, 2017 via email

@cholcombe973
Copy link
Author

@sergiusens I think this should fix it up

@sergiusens
Copy link
Collaborator

i am seeing things like
Expected: [call(['/tmp/tmp_345efam/parts/test-part/rust/sh.rustup.rs', '--prefix=/tmp/tmp_345efam/parts/test-part/rust', '--disable-sudo', '--save', '--channel=nightly']), call(['/tmp/tmp_345efam/parts/test-part/rust/bin/cargo', 'fetch', '--manifest-path', '/tmp/tmp_345efam/parts/test-part/src/Cargo.toml'])]
Actual: [call(['/tmp/tmp_345efam/parts/test-part/rust/rustup.sh', '--prefix=/tmp/tmp_345efam/parts/test-part/rust', '--disable-sudo', '--save', '--channel=nightly']),
call(['/tmp/tmp_345efam/parts/test-part/rust/bin/cargo', 'fetch', '--manifest-path', '/tmp/tmp_345efam/parts/test-part/src/Cargo.toml'])]

come-maiz
come-maiz previously approved these changes Feb 8, 2017
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this one supports aarch64!
Do you know where is the git repository for this script?

@cholcombe973
Copy link
Author

@ElOpio I do. It's here: https://github.com/rust-lang-nursery/rustup.rs :)

Rustup has changed over to a new location .
@sergiusens
Copy link
Collaborator

@ElOpio @cholcombe973 reading the script it still doesn't support 64 bit kernels on 32 bit user spaces

@cholcombe973
Copy link
Author

Ah crap I broke a bunch of things. This new rustup script doesn't act like the previous one. Let me work this out.

@cholcombe973
Copy link
Author

I think i need to abandon this change. The new rustup is significantly different from the old one and it no longer supports an install prefix.

@sergiusens sergiusens dismissed come-maiz’s stale review February 9, 2017 12:17

it doesn't work :-)

@sergiusens
Copy link
Collaborator

should we close this or re-evaluate. I suppose we can propose fixes upstream. They reviewed my stuff pretty quick last time.

@cholcombe973
Copy link
Author

cholcombe973 commented Feb 9, 2017 via email

@kyrofa
Copy link
Contributor

kyrofa commented Feb 10, 2017

Alright, closing for now.

@kyrofa kyrofa closed this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants