kernel plugin: if dtb target == NULL and arch == (arm||arm64), build and install all dtbs #1148
Conversation
|
mind updating the unit tests here? |
…and install all dtbs Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
| @@ -863,15 +863,15 @@ def test_kernel_image_target_as_map(self): | |||
| plugin = kernel.KernelPlugin('test-part', self.options, | |||
| project_options) | |||
|
|
|||
| self.assertEqual(plugin.make_targets, ['Image', 'modules']) | |||
| self.assertEqual(plugin.make_targets, ['Image', 'modules', 'dtbs']) | |||
There was a problem hiding this comment.
Do we have any tests that cover when not building on these architectures, and thus makes sure dtbs aren't built for them?
There was a problem hiding this comment.
Yes we do although not directly visible on https://github.com/snapcore/snapcraft/pull/1148/files#diff-6f5410d7a6a3500fab904417fc36123dR779
We should probably refactor the kernel tests into many smaller classes but Paolo shouldn't be the one to do that.
| self.make_targets.append('dtbs') | ||
| self.make_install_targets.extend([ | ||
| 'dtbs_install', | ||
| 'INSTALL_DTBS_PATH={}/dtbs'.format(self.installdir)]) |
There was a problem hiding this comment.
We also run this tests in armhf and arm64. The tests were not updated to take into account that they could be running on these architectures, so now we have new failures:
This is pretty important, because we can't land in the archives if the tests start failing. @piso77, can you please take a look?
…hem all. (#1148) Build all dtbs if no specific dtb is requested on architectures that support dtbs. LP: #1665656 Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
…hem all. (canonical#1148) Build all dtbs if no specific dtb is requested on architectures that support dtbs. LP: #1665656 Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
If dtb target == NULL and arch == (arm||arm64), build and install all dtbs by default.
Signed-off-by: Paolo Pisati paolo.pisati@canonical.com
LP: #1665656