tests: run the CLA check in a docker container. #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing the CLA check out of the docker container to save a few minutes, but it's affecting the trigger from the store. With this change, all the tests are uniform and the store trigger can be customized more easily. LP: #1672788
added 2 commits
March 14, 2017 17:25
come-maiz
pushed a commit
that referenced
this pull request
Mar 27, 2017
We were doing the CLA check out of the docker container to save a few minutes, but it's affecting the trigger from the store. With this change, all the tests are uniform and the store trigger can be customized more easily. LP: #1672788
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
We were doing the CLA check out of the docker container to save a few minutes, but it's affecting the trigger from the store. With this change, all the tests are uniform and the store trigger can be customized more easily. LP: #1672788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing the CLA check out of the docker container to save a few minutes,
but it's affecting the trigger from the store. With this change, all the tests
are uniform and the store trigger can be customized more easily.
LP: #1672788