New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrations: use the snapcore/snapcraft docker image in travis #1331
integrations: use the snapcore/snapcraft docker image in travis #1331
Conversation
@filibtester thanks for the fix! |
@@ -210,7 +210,6 @@ def test_enable_successfully( | |||
"Enabling Travis testbeds to push and release 'foo' snaps " | |||
"to edge channel in series '16'", | |||
'Acquiring specific authorization information ...', | |||
'Login successful.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other reviewers, this change is interesting. Take a look that @filibtester moved the file, because it wasn't being run by ./runtests.sh unit.
So this test got stale, and started failing without us noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filibtester nice catch! Thank you.
This is missing one more +1. @kalikiana or @kyrofa, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing one more +1. @kalikiana or @kyrofa, please take a look.
Haha, as far as I can see, it doesn't have a +1 from you either! This looks good to me, but I'd appreciate a quick look from @cprov as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot my approval.
The change looks good and will certainly bump usage of the snapcraft docker image. Just a small remark, this change doesn't offer any alternative for updating existing integrations, |
@cprov That's a good point, about the existing integrations out there. However, keeping the old image is safe, as it takes care of upgrading snapcraft and will result in the same snap. And the work required to migrate those old projects would be complex, not required IMO. I'm going to merge this one. |
Thanks for helping us make a better Snapcraft!
Checklist:
Have you signed the contributor licence agreement?
https://www.ubuntu.com/legal/contributors
Is there a reported a bug for the problem you are fixing?
https://bugs.launchpad.net/snapcraft/
If there is none, please report it. Once you have the BUG_NUMBER,
replace it here:
LP: #BUG_NUMBER
CONTRIBUTING.md