New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better explain dependency link processing #1402
Better explain dependency link processing #1402
Conversation
@@ -36,7 +36,8 @@ | |||
Path to a constraints file | |||
- process-dependency-links: | |||
(bool; default: false) | |||
Enable the processing of dependency links. | |||
Enable the processing of dependency links in pip, which allow one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You wouldn't say "dependency links allows one project to provide …", you'd say "dependency links allow one project to provide…"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, I read without the back context.
@@ -39,7 +39,8 @@ | |||
Path to a constraints file | |||
- process-dependency-links: | |||
(bool; default: false) | |||
Enable the processing of dependency links. | |||
Enable the processing of dependency links in pip, which allow one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows?
@@ -39,7 +39,8 @@ | |||
Path to a constraints file | |||
- process-dependency-links: | |||
(bool; default: false) | |||
Enable the processing of dependency links. | |||
Enable the processing of dependency links in pip, which allow one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis says this is red, but it is all green when I check manually. This is only text so merging away here
As covered in https://github.com/CanonicalLtd/snappy-docs/pull/87#discussion_r126335736, better explain dependency link processing.