lxd: path cannot have extra forward slashes #1483

Merged
merged 1 commit into from Aug 15, 2017

Conversation

3 participants
Collaborator

kalikiana commented Aug 11, 2017

After double-checking that the logic for mounting the project folder on the Snapcraft side I ended up finding that LXD can end up claiming the device exists without actually mounting it. In that case lxc device remove aborts with internal errors.
Apparently the LXD issue can be avoided by getting rid of a leading / in the mounted path.

This fixes Could not find snap/snapcraft.yaml.

Notes:

  • I'm not especially happy with the test side of this, it's a virtually invisible change. Suggestions would be welcome.
  • Maybe we should be moving to using lxc edit for configuration as it can be used to fix containers that would be stuck using dedicated commands.
Collaborator

sergiusens commented Aug 11, 2017

Once @elopio's branch lands for container testing we can extend these tests, just add a personal note or bug in launchpad to keep track of it.

@kalikiana kalikiana self-assigned this Aug 11, 2017

@sergiusens sergiusens added this to the 2.34 milestone Aug 14, 2017

@sergiusens sergiusens added the bug label Aug 14, 2017

Member

elopio commented Aug 15, 2017

@kalikiana I see that path still has two slashes:

'path=//root/build_basic'

Could that be a problem?

I was able to build the snap in containers many times, so +1, just pending on the answer to that question.

Collaborator

kalikiana commented Aug 15, 2017

@elopio If by still you mean an existing container, yes, the bug won't be fixed for that container. As mentioned in the description, lxc config edit seems to be the only way to fix that. I'm looking into that, but it'll be more invasive changes.

@sergiusens sergiusens added this to Container builds in 17.10 Aug 15, 2017

@sergiusens sergiusens merged commit 1a3c02b into snapcore:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kalikiana added a commit to kalikiana/snapcraft that referenced this pull request Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment