Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd: path cannot have extra forward slashes #1483

Merged
merged 1 commit into from Aug 15, 2017

Conversation

kalikiana
Copy link
Contributor

@kalikiana kalikiana commented Aug 11, 2017

After double-checking that the logic for mounting the project folder on the Snapcraft side I ended up finding that LXD can end up claiming the device exists without actually mounting it. In that case lxc device remove aborts with internal errors.
Apparently the LXD issue can be avoided by getting rid of a leading / in the mounted path.

This fixes Could not find snap/snapcraft.yaml.

Notes:

  • I'm not especially happy with the test side of this, it's a virtually invisible change. Suggestions would be welcome.
  • Maybe we should be moving to using lxc edit for configuration as it can be used to fix containers that would be stuck using dedicated commands.

@sergiusens
Copy link
Collaborator

Once @ElOpio's branch lands for container testing we can extend these tests, just add a personal note or bug in launchpad to keep track of it.

@kalikiana kalikiana self-assigned this Aug 11, 2017
@sergiusens sergiusens added this to the 2.34 milestone Aug 14, 2017
@sergiusens sergiusens added the Bug Actual bad behavior that don't fall into maintenance or documentation label Aug 14, 2017
@come-maiz
Copy link
Contributor

@kalikiana I see that path still has two slashes:

'path=//root/build_basic'

Could that be a problem?

I was able to build the snap in containers many times, so +1, just pending on the answer to that question.

@kalikiana
Copy link
Contributor Author

@ElOpio If by still you mean an existing container, yes, the bug won't be fixed for that container. As mentioned in the description, lxc config edit seems to be the only way to fix that. I'm looking into that, but it'll be more invasive changes.

@sergiusens sergiusens added this to Container builds in 17.10 Aug 15, 2017
@sergiusens sergiusens merged commit 1a3c02b into canonical:master Aug 15, 2017
kalikiana added a commit to kalikiana/snapcraft that referenced this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Actual bad behavior that don't fall into maintenance or documentation
Projects
17.10
Container builds
Development

Successfully merging this pull request may close these issues.

None yet

3 participants