Join GitHub today
python plugin: record manifest #1487
It feels like storing the requirements file is almost informational now, isn't it?
Given that we record the exact packages to install and can potentially use constraints to avoid some weird behaviour (unbeknownst to us) of pip picking packages outside of what was locked down. I guess the reason we store requirements files is in case it is something external to the sources of the project.
I don't have any critique here, just thinking out loud as this has prevented me from reviewing properly since I first saw the PR Monday night.
Since testing was brought up, now that we are using testtools, I much prefer
since in the latter when writing (made easier with good variable naming) or executing it is never clear what is what you wanted versus what you got.
Agreed, especially when you consider that, with testtools, it's
Looks good, but please improve the check for locality of requirements txt in new PR, this should be implemented in sources to verify a file is actually committed into the VCS