cli: don't raise from excepthook #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
approved these changes
Aug 19, 2017
Raising exceptions from `excepthook` does not seem to be expected by Python, causing it to print "Error in sys.excepthook: [...]" which may look a little confusing. Instead of raising again and relying on Python to further handle the exception, print the traceback ourselves and exit appropriately. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/excepthook_no_raise
branch
from
a93c345
to
20b3794
Compare
come-maiz
approved these changes
Aug 22, 2017
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
Raising exceptions from `excepthook` does not seem to be expected by Python, causing it to print "Error in sys.excepthook: [...]" which may look a little confusing. Instead of raising again and relying on Python to further handle the exception, print the traceback ourselves and exit appropriately. Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising exceptions from
excepthookdoes not seem to be expected by Python, causing it to print "Error in sys.excepthook: [...]" which may look a little confusing, as theexcepthookhas nothing to do with the error. Instead of raising again and relying on Python to further handle the exception, print the traceback ourselves and exit appropriately.